pkg/plugins/log/fake.go (1)

46-48: FromContext returns a disconnected logger — log assertions may silently miss entries.

FromContext returns a brand-new TestLogger with its own Logs fields, just like New does. Any code path that calls logger.FromContext(ctx).Info(...) (e.g., LoggerMiddleware.logRequest) will write to a logger that no test holds a reference to, so assertions on the original TestLogger's InfoLogs, ErrorLogs, etc. will never see those entries.

If test coverage for LoggerMiddleware log output matters, consider returning the receiver (f) instead, or at least documenting this behavior.

Possible fix (return receiver)

 func (f *TestLogger) FromContext(_ context.Context) Logger {
-	return NewTestLogger()
+	return f
 }

pkg/services/pluginsintegration/clientmiddleware/metrics_middleware_test.go (1)

21-21: Test function name is stale after the rename.

The type was renamed from InstrumentationMiddleware to MetricsMiddleware, but the test function is still TestInstrumentationMiddleware. Consider renaming it to TestMetricsMiddleware for consistency.

pkg/services/pluginsintegration/clientmiddleware/metrics_middleware.go (1)

75-82: Stale variable name imw (instrumentation middleware).

imw is a leftover abbreviation from InstrumentationMiddleware. Consider renaming to mmw or mw for consistency with the MetricsMiddleware type.

Suggested rename

 func NewMetricsMiddleware(promRegisterer prometheus.Registerer, pluginRegistry registry.Service) plugins.ClientMiddleware {
-	imw := newMetricsMiddleware(promRegisterer, pluginRegistry)
+	mw := newMetricsMiddleware(promRegisterer, pluginRegistry)
 	return plugins.ClientMiddlewareFunc(func(next plugins.Client) plugins.Client {
-		imw.next = next
-		return imw
+		mw.next = next
+		return mw
 	})
 }

pkg/plugins/log/ifaces.go (1)

21-23: Doc comment for FromContext is identical to New and doesn't convey the distinction.

Line 22 says "returns a new contextual Logger that has this logger's context plus the given context" — the same wording as New on line 7. FromContext retrieves logger attributes stored in a context.Context (e.g., by middleware), whereas New accepts explicit key/value pairs. Consider making the doc more specific.

Suggested doc

-	// FromContext returns a new contextual Logger that has this logger's context plus the given context.
+	// FromContext returns a Logger enriched with attributes previously stored in the given context.
 	FromContext(ctx context.Context) Logger

pkg/services/pluginsintegration/clientmiddleware/contextual_logger_middleware.go (1)

59-69: Consider instrumenting stream methods for consistency.

SubscribeStream, PublishStream, and RunStream all have access to req.PluginContext but skip instrumentContext. This means downstream middleware/handlers for streaming won't have the contextual logging attributes. If this omission is intentional (e.g., long-lived streams where per-request context is less useful), a brief comment explaining the rationale would help future readers.